[SYCL][L0] Fix absence of zeInit in Level Zero LIT e2e tests #18956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igchor
approved these changes
Jun 12, 2025
dm-vodopyanov
changed the title
Comment on lines
+64
to
+65
| // Initialize Level Zero driver is required if this test is linked | ||
| // statically with Level Zero loader, the driver will not be init otherwise. |
There was a problem hiding this comment.
small nit here and below in other tests:
Suggested change
| // Initialize Level Zero driver is required if this test is linked | |
| // statically with Level Zero loader, the driver will not be init otherwise. | |
| // Initializing Level Zero driver is required if this test is linked | |
| // statically with Level Zero loader, otherwise the driver will not be initialized. |
| // statically with Level Zero loader, the driver will not be init otherwise. | ||
| ze_result_t result = zeInit(ZE_INIT_FLAG_GPU_ONLY); | ||
| if (result != ZE_RESULT_SUCCESS) { | ||
| std::cout << "zeInit failed\n"; |
There was a problem hiding this comment.
This test use asserts, so to align with it:
Suggested change
| std::cout << "zeInit failed\n"; | |
| assert((result == ZE_RESULT_SUCCESS) && "zeInit failed"); |
| // statically with Level Zero loader, the driver will not be init otherwise. | ||
| ze_result_t result = zeInit(ZE_INIT_FLAG_GPU_ONLY); | ||
| if (result != ZE_RESULT_SUCCESS) { | ||
| std::cout << "zeInit failed\n"; |
There was a problem hiding this comment.
nit here and in other tests below:
Suggested change
| std::cout << "zeInit failed\n"; | |
| std::cerr << "zeInit failed" << std::endl; | |
Comment on lines
+26
to
+27
| if (result != ZE_RESULT_SUCCESS) { | ||
| std::cout << "zeInit failed\n"; |
There was a problem hiding this comment.
Better to use assert here as it is already used in this test
| ze_result_t result = zeInit(ZE_INIT_FLAG_GPU_ONLY); | ||
| if (result != ZE_RESULT_SUCCESS) { | ||
| std::cout << "zeInit failed\n"; | ||
| return 1; |
There was a problem hiding this comment.
+ some small enhancement here and below:
Suggested change
| return 1; | |
| return result; |
There was a problem hiding this comment.
ZE_RESULT_SUCCESS is not equal to test's success return code. May be in current implementation both of them are equal 0, but not in general.
There was a problem hiding this comment.
Maybe print this result value to output for the future easier debugging session, or return it in other way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.